-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display coercions with a type ascription #6119
Conversation
Mathlib CI status (docs):
|
By the way, I edited the PR description to say "towards" instead of "closes" because I think there are things we can do to If it's something you want to try working on, and you are OK with your work potentially being discarded, feel free to go ahead. I just wrote up some ideas for how to do it intelligently, but I deleted them because it's unclear whether it would actually work. Probably the simplest for now would be to make |
I changed the new option to default to false. It makes sense for two reasons: compatibility with current tests, and looking disruptive in the infoview.
It seems to me that it belongs to a separate PR. Shall we discuss how to proceed on Zulip before I start working on |
Could you please add some tests? How about in tests/lean/run/coeAttr.lean, and use module docstrings like in lean/run/conv_arg.lean to say what each test is trying to accomplish. Two tests, one with the option false and one with the option true, should be sufficient. |
I've added some very basic tests. |
This PR adds a new delab option `pp.coercions.types` which, when enabled, will display all coercions with an explicit type ascription. [Link to Zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/239415-metaprogramming-.2F-tactics/topic/Roundtripping.20delaboration.20involving.20coercions) Towards leanprover#4315
This PR adds a new delab option
pp.coercions.types
which, when enabled, will display all coercions with an explicit type ascription.Link to Zulip discussion
Towards #4315