perf: remove @[specialize] from mkBinding
#6019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 9, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 9, 2024
leanprover-community-bot
added
the
builds-mathlib
|
!bench |
Would you mind including the link to the speed center report, for posterity? |
|
Here are the benchmark results for commit cd2ca0a. Benchmark Metric Change
=====================================================
- bv_decide_mul branch-misses 2.5% (10.1 σ)
- bv_decide_realworld branch-misses 1.2% (16.5 σ) |
|
I'm surprised by the improvement: stdlib | instructions | | -90,535 σ | 6,069 bln. | -6,722 mld. -0,111 % | 6,063 bln. |
JovanGerb
added a commit
to JovanGerb/lean4
that referenced
this pull request
Jan 21, 2025
This PR removes @[specilize] from `MkBinding.mkBinding`, which is a function that cannot be specialized (as none of its arguments are functions). As a result, the specializable function `Nat.foldRevM.loop` doesn't get specialized, which leads to worse performing code. As expected, the mathlib bench shows a very small improvement. About 95% of files show a speedup. (http://speed.lean-fro.org/mathlib4/compare/e7b27246-a3e6-496a-b552-ff4b45c7236e/to/6033df75-aa53-44d9-819d-51f93fc05e94?hash1=b28f0d7f7e9cc3949a9a3556a6b36513f37f690d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes @[specilize] from
MkBinding.mkBinding, which is a function that cannot be specialized (as none of its arguments are functions). As a result, the specializable functionNat.foldRevM.loopdoesn't get specialized, which leads to worse performing code.As expected, the mathlib bench shows a very small improvement. About 95% of files show a speedup. (http://speed.lean-fro.org/mathlib4/compare/e7b27246-a3e6-496a-b552-ff4b45c7236e/to/6033df75-aa53-44d9-819d-51f93fc05e94?hash1=b28f0d7f7e9cc3949a9a3556a6b36513f37f690d)