fix: solveByElim would add symm hypotheses to local context and make impossible-to-elaborate terms #3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@semorrison I took a stab at this issue. It's likely a performance regression, but it's a big usability improvement, so maybe it's ok in the meantime? Feel free to take over from here. (Big warning: I did very little testing of this PR!) |
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
…impossible-to-elaborate terms Rather than adding symm hypotheses to the local context, it now adds them to the list of hypotheses derived from the local context. This is not idea for performance reasons, but it at least closes leanprover#3922. In the future, solveByElim could maintain its own cache of facts that it updates whenever it does intro.
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 20, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 20, 2024
leanprover-community-mathlib4-bot
added
the
breaks-mathlib
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 20, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 20, 2024
|
Adding |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 22, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 22, 2024
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 22, 2024
|
Mathlib is easy enough to fix (pushed to lean-pr-testing-3962). Agree we need to fix this despite the possible performance problems. |
leanprover-community-mathlib4-bot
added
builds-mathlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than adding symm hypotheses to the local context, it now adds them to the list of hypotheses derived from the local context.
This is not ideal for performance reasons, but it at least closes #3922.
In the future, solveByElim could maintain its own cache of facts that it updates whenever it does intro.