-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add model implementation for UTF8 enc/dec #3961
Conversation
Mathlib CI status (docs):
|
Could you add a basic test file using
and then similarly for the other functions? |
LGTM, but I'm not the one to merge changes to UTF8 handling! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff, minor comments only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. test_extern
improvement can be generalized in a separate PR. Happy to merge if you are happy with this.
This makes the UTF-8 encode and decode functions have lean definitions, so that we can prove properties about them downstream.