feat: hover / go-to-def for attribute cmd
#3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
force-pushed
the
attribute_hover
branch
from
93b471e to
3a18ccc
Compare
github-actions
bot
added
the
toolchain-available
digama0
force-pushed
the
attribute_hover
branch
from
3a18ccc to
32d381e
Compare
nomeata
reviewed
Apr 13, 2024
src/Lean/Elab/Declaration.lean
Outdated
| else | ||
| throwUnknownConstant name | ||
| let declName ← ensureNonAmbiguous ident declNames | ||
| try some <$> realizeGlobalConst ident |
There was a problem hiding this comment.
Don't we have realizeGlobalConstWithInfo or the like?
There was a problem hiding this comment.
The FIXME in this code is because we are using realizeGlobalConst even though sometimes it's not a valid declaration but a simproc instead. So some of the code from these functions is inlined here to ensure the error handling is done right.
I think it would be possible to use realizeGlobalConstWithInfos here and only do the ambiguity handling separately, although it has slightly different error behavior.
digama0
force-pushed
the
attribute_hover
branch
from
32d381e to
c071b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attribute [attr] foowas missing a hover onfoo.