fix: avoid "Argument list is too large" on building via nix. #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x450x6c
force-pushed
the
fix-nix-build-when-too-many-deps
branch
from
5bacd9f to
0f04882
Compare
The buildLeanPackage uses environment variable to store a list of libraries, then passes that variable to the lean as CLI arguments. According to this (https://stackoverflow.com/a/28865503), CLI arguments and environment variables share same space, therefore there is an error "Argument list is too large" when building a package with too many components. (for example - mathlib4) This change makes buildLeanPackage to use a file instead of environment variable to store a list of libraries.
0x450x6c
force-pushed
the
fix-nix-build-when-too-many-deps
branch
from
0f04882 to
b8fece8
Compare
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 22, 2023
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
|
The Nix integration has been deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
buildLeanPackageuses environment variable to store a list of libraries,then passes that variable to the lean as CLI arguments.
According to this (https://stackoverflow.com/a/28865503), CLI arguments and environment variables share same space, therefore there is an error "Argument list is too large" when building a package with too many components.
(for example - mathlib4)
This change makes
buildLeanPackageto use a file instead of environment variable to store a list of libraries.Put an X in this bracket to confirm you have read the
External Contribution Guidelines.
Please put the link to your
RFCorbugissue here.PRs missing this link will be marked as
missing RFC.Didn't created an issue, because patch is trivial.