doc: document Lean.Elab.StructInst #1928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provide both a short and long overview of how the code here works
kmill
added a commit
to kmill/lean4
that referenced
this pull request
Nov 18, 2024
This PR does some mild refactoring of the `Lean.Elab.StructInst` module while adding documentation. Documentation is drawn from @thorimur's leanprover#1928.
|
Thanks! I've incorporated a good amount of this into refactoring at #6110. |
JovanGerb
pushed a commit
to JovanGerb/lean4
that referenced
this pull request
Jan 21, 2025
This PR does some mild refactoring of the `Lean.Elab.StructInst` module while adding documentation. Documentation is drawn from @thorimur's leanprover#1928.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds:
Lean.Elab.StructInst, which gives an overview of how the code for structure instance elaboration worksLean.Elab.StructInstNote: I'm aware this isn't the usual contribution process; however, I was encouraged on Zulip to make this pull request directly (i.e. without making an issue first) since this is a small PR (in the sense of no functionality being introduced).