New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ToExpr Int instance #58

Merged

eric-wieser merged 1 commit into master from eric-wieser-patch-1

Oct 5, 2024

Member

eric-wieser commented Oct 5, 2024 •

edited

Loading

This instance exists both upstream in core and downstream in mathlib (see Zulip).

The one upstream uses toExpr (-1) = q(-1), which is probably preferable to the toExpr (-1) = q(Int.negSucc 0) used here.


          Remove the ToExpr Int instance

c64bdcc

This instance exists upstream in core

eric-wieser merged commit 2b2f6d7 into master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet