feat: lift to expressions, vacuous and random_search tactics #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Nov 29, 2024
| @@ -262,6 +296,9 @@ instance [SampleableExt α] [SampleableExt β] : SampleableExt ((_ : α) × β) | |||
| let p ← prodOf sample sample | |||
| return ⟨p.fst, p.snd⟩ | |||
| interp s := ⟨interp s.fst, interp s.snd⟩ | |||
| proxyExpr? := none -- did not understand the difference with products | |||
There was a problem hiding this comment.
To be clear, this is Sigma not Prod.
There was a problem hiding this comment.
Thanks. Indeed the documentation said so but I missed this. Will fix.
eric-wieser
reviewed
Nov 29, 2024
eric-wieser
reviewed
Nov 29, 2024
| @@ -242,6 +260,18 @@ section Samplers | |||
|
|
|||
| open SampleableExt | |||
|
|
|||
| instance instToExprSum [ToExpr α] [ToExpr β] : ToExpr (α ⊕ β) := | |||
There was a problem hiding this comment.
Note that the use of levelZero in this instance is incorrect, which means that mathlib will have to make a copy of this instance and the one below (using Mathlib's Lean.ToLevel)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetaTestableis introduced that is similar toTestablebut also keeps track of expressions for counterexamples by copying and modifying the code.MetaTestablecan be inferred. There are limitations as in addition toSampleableExtwe needToExprfor the proxy type to build expressions.vacuousandrandom_search.vacuoustactic tries to negate (a part of the) hypothesis to prove by vacuous implication.random_searchtactic negates the goal and tries to disprove it.