Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the replacement style used for mathlib3port to keep #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eric-wieser
Copy link
Member

These #prints and surrounding comments are annoying to remove when re-porting files, and having the declarations commented out isn't particularly useful anyway.

The real motivation here is to make mathport produce a tree that is suitable for inserting between the mathlib3 and mathlib4 history, with ideally-minimal diffs

These `#print`s and surrounding comments are annoying to remove when re-porting files, and having the declarations commented out isn't particularly useful anyway.

The real motivation here is to make mathport produce a tree that is suitable for inserting between the mathlib3 and mathlib4 history, with ideally-minimal diffs
@eric-wieser eric-wieser requested a review from digama0 July 20, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant