refactor: separate out PGame.relabelling
#7162
Open
+486
−408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is the first step to remove `PGame.Relabelling` (which is only for implementing things in lean and not real identity) and define games with identity as `Eq`.
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
FR-vdash-bot
removed
the
merge-conflict
leanprover-community-bot-assistant
added
the
merge-conflict
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on: |
LeoDog896
reviewed
Jan 22, 2025
| @[deprecated (since := "2024-09-26")] alias equiv_of_mk_equiv := Equiv.of_equiv | ||
|
|
||
| theorem Equiv.isEmpty (x : PGame) [IsEmpty x.LeftMoves] [IsEmpty x.RightMoves] : x ≈ 0 := |
There was a problem hiding this comment.
This is the only 'major' change of the earlier merge conflict resolution: the newer theorem birthday_eq_zero relies on Equiv.isEmpty - I've moved it and proved it separately of Relabelling.
leanprover-community-bot-assistant
removed
the
merge-conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zulip
PGame.identicalPGame.memₗPGame.memᵣAPIs #5901diff