Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(Zulip reaction): add emoji_code and realm_emoji for :closed-pr: #20941

Closed
wants to merge 1 commit into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jan 22, 2025

I forgot that for custom emoji, the Zulip API to remove reactions requires also the code and realm_emoji, possibly not both, but certainly at least one!


Open in Gitpod

Copy link

PR summary 0b1b573ffb

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 22, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 22, 2025
…#20941)

I forgot that for custom emoji, the Zulip API to remove reactions requires also the code and realm_emoji, possibly not both, but certainly at least one!
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 22, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(Zulip reaction): add emoji_code and realm_emoji for :closed-pr: [Merged by Bors] - fix(Zulip reaction): add emoji_code and realm_emoji for :closed-pr: Jan 22, 2025
@mathlib-bors mathlib-bors bot closed this Jan 22, 2025
@mathlib-bors mathlib-bors bot deleted the adomani/remove_closed_pr_reaction_really branch January 22, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants