Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: rename List.indexOf_lt_length to List.indexOf_lt_length_iff #20939

Closed
wants to merge 3 commits into from

Conversation

jcommelin
Copy link
Member


Open in Gitpod

Copy link

PR summary 9004ae4b70

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ indexOf_lt_length_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@@ -1,4 +1,4 @@
#! /bin/bash
#! /usr/bin/env bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change, but I wonder whether you were meaning to include it in this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the script and, if I had remembered, I would have used what Johan placed here: happy to include it in this PR!

@adomani
Copy link
Collaborator

adomani commented Jan 22, 2025

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 22, 2025

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Copy link
Member Author

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 22, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: rename List.indexOf_lt_length to List.indexOf_lt_length_iff [Merged by Bors] - chore: rename List.indexOf_lt_length to List.indexOf_lt_length_iff Jan 22, 2025
@mathlib-bors mathlib-bors bot closed this Jan 22, 2025
@mathlib-bors mathlib-bors bot deleted the jmc-indexOf_lt_length_iff branch January 22, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants