chore: golf using List.toArrayMap
#20613
Open
+27
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids an intermediate allocation, so hopefully is faster.
- Move one toList call one level up. - make rankSums return an array; this works just as well - replace .toList.reduceOption.toArray by filterMap
github-actions
bot
added
the
large-import
PR summary 5a6c800bc2Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Util.GetAllModules | 19 | 20 | +1 (+5.26%) |
| Mathlib.Util.CompileInductive | 21 | 22 | +1 (+4.76%) |
| Mathlib.Tactic.ToAdditive.Frontend | 47 | 48 | +1 (+2.13%) |
| Mathlib.Tactic.DeriveTraversable | 89 | 90 | +1 (+1.12%) |
| Mathlib.Lean.Meta.RefinedDiscrTree.Lookup | 117 | 118 | +1 (+0.85%) |
| Mathlib.Tactic.MoveAdd | 135 | 136 | +1 (+0.74%) |
Import changes for all files
| Files | Import difference |
|---|---|
| There are 5237 files with changed transitive imports taking up over 220191 characters: this is too many to display! | |
You can run scripts/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
Might be worth pointing out this is only being done with tactics; there's no mathematical benefit in this substitution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on batteries#1090 landing in mathlib.