naming advice around inj and ext
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
reviewed
Jun 14, 2020
urkud
reviewed
Jun 14, 2020
kim-em
commented
Jun 14, 2020
kim-em
commented
Jun 14, 2020
|
I think it's good to codify what has been an implicit naming practice already. I'm fine with merging this. @bryangingechen @robertylewis @digama0 any comments? |
|
I'm happy with merging this too. |
|
I'm not entirely up on the naming conventions but this looks fine to me. I don't think the trailing |
They're just there for consistency with the rest of the file, I think. We can get rid of them in a cleanup pass later on. See #62 as well as the duplicated variable names table in style.md. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.