Add opensearch support to the mathlib docs #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't really come up with a way of testing this other than deploying it and seeing what happens. |
|
Thanks for merging this. Now that I can test it, it seems that this doesn't actually work in chrome :( Maybe it works in firefox like @gebner said leanprover-community/doc-gen#161 did? Either way, if it doesn't work in chrome we may as well revert this and put the change in doc-gen instead. |
|
I don't think this is deployed yet. At least I can't find any mention of |
|
The jobs I re-ran just finished, so hopefully it's deployed now? |
|
Can confirm that it works on firefox. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make supported browsers offer a "search mathlib docs" feature in the title bar.
It's not clear to me whether this will work in the mathlib doc repo, there are rumors online that it has to be at the site root.
I'll make a PR there anyway to test (leanprover-community/doc-gen#161)