Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milestone 3: Breaking Refactor #96

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

Milestone 3: Breaking Refactor #96

wants to merge 21 commits into from

Conversation

mekeor
Copy link
Collaborator

@mekeor mekeor commented Dec 6, 2024

No description provided.

@mekeor mekeor force-pushed the milestone-03-breaking-refactor branch 2 times, most recently from 8802d2e to 37bb4c8 Compare December 8, 2024 23:34
@mekeor mekeor force-pushed the milestone-03-breaking-refactor branch 2 times, most recently from a8916aa to 1754b21 Compare December 12, 2024 21:35
mekeor added 12 commits December 12, 2024 23:28
@mekeor
Rework lean4-mode-hook; extract logic into its new member defuns
1e9e786 
Use (bound-and-true-p flycheck-mode) instead of just flycheck-mode.

Remove flycheck-mode from lean4-mode-hook because it should be spawned
by lsp-mode depending on lsp-diagnostics-provider variable.
@mekeor
Dissolve lean4-settings
18b1aec 
Fixes issue #88 "Remove lean4-keybinding-* user options and dissolve
other parts of
lean4-settings.el"
(<#88>).
@mekeor
Delete lean4-dev
c95b87a 
Because it has too few instructions on how to use it.
@mekeor
Delete lean4-debug
ca5cd33 
Because it does not work.
@mekeor
Use "Lean4" in docstrings, for input method; name info "*Lean4 Info*"
67f4900
@mekeor
Remove old, personal, unused developer code
a053cdb
@mekeor
Move -lake into -util
324f7fe
@mekeor
Do not use inexistent customize group lake but lean4
8dc5e93
@mekeor
Remove redundant lean4-std-exe in favor of equal lean4-execute
02ebcf8
@mekeor
Do not use tabs in Elisp code
4622916 
Replace tabs with spaces.  Reindent changed code.  Directory-locally
set indent-tabs-mode to nil for emacs-lisp-mode.
@mekeor
Fix wrong usage of let*
49ab242
@mekeor
Properly use (interactive)
ce72e4e
@mekeor mekeor force-pushed the milestone-03-breaking-refactor branch 2 times, most recently from 628ff0f to cbd02ea Compare January 13, 2025 01:45
mekeor added 2 commits January 16, 2025 00:25
@mekeor
Dissolve -util in favor of -mode and new -exec
ea00b85 
The lean4-exec.el feature has been written from scratch.  Its logic is
simple: For Elan, Lake and Lean respectively, there is a hook of
functions which may return a path to the respective program.  Well,
there are some more details to it but its great at being minimalist
but scalable.
@mekeor
Extract init functions to -eri, -input and -exec; add them to hook
1305317
@mekeor mekeor force-pushed the milestone-03-breaking-refactor branch from cbd02ea to 1305317 Compare January 15, 2025 23:28
mekeor
mekeor commented Jan 17, 2025
View reviewed changes
.dir-locals.el Show resolved Hide resolved
@mekeor
Copy link
Collaborator Author

mekeor commented Jan 17, 2025

TODO: Describe changes in changelog and also explain how to upgrade.

@mekeor
Copy link
Collaborator Author

mekeor commented Jan 17, 2025

TODO: Somehow "cache" result of lean4-exec-init, e.g. per lsp-mode session metadata?

@mekeor
Copy link
Collaborator Author

mekeor commented Jan 17, 2025

TODO: Fix melpazoid errors.

@mekeor
Copy link
Collaborator Author

mekeor commented Jan 17, 2025

TODO: Properly define customization group lean4-exec.

@mekeor
Copy link
Collaborator Author

mekeor commented Jan 17, 2025 •
edited
Loading

@urkud: This PR is quite big and the commits are not as clean and streamlined as in prior PRs. Do you want me to "rebase" (reorder, squash, amend etc) the commits so that they are easily reviewable one by one? Or are you fine with reviewing the whole PR altogether?

The biggest change is that lean4-lake.el has been replaced with an entirely new lean4-exec.el file that aims to locate the executables of Elan, Lake and Lean so that they can be used to build/compile, start LSP server and (WIP) execute some other shell command.

Another important change is that some functionality of lean4-mode (the major mode / function) is moved out to functions that are members of the lean4-mode-hook. This makes Lean4-Mode more modular and configurable and is some pre-work to dropping the hard dependency on LSP-Mode.

@mekeor
Copy link
Collaborator Author

mekeor commented Jan 17, 2025

TODO: Reimplement a lean4-exec command for arbitrary shell commands.

@mekeor
Copy link
Collaborator Author

mekeor commented Jan 17, 2025

TODO: Fix #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mekeor