-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Lean version and replace std
to batteries
#150
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
leanprover/lean4:v4.7.0 | ||
leanprover/lean4:v4.15.0-rc1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -386,7 +386,7 @@ elab "custom_assump_2" : tactic => | |
then return Option.some declExpr | ||
else return Option.none | ||
match option_matching_expr with | ||
| some e => Lean.Elab.Tactic.closeMainGoal e | ||
| some e => Lean.Elab.Tactic.closeMainGoal `custom_assump_2 e | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm only scanning the PR so apologies for not trying to figure this out myself, but can you say something about what's happening here with the extra argument? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
| none => | ||
Lean.Meta.throwTacticEx `custom_assump_2 goal | ||
(m!"unable to find matching hypothesis of type ({goalType})") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we use the corresponding tag -- i.e. https://github.com/leanprover-community/batteries/releases/tag/v4.15.0-rc1 -- so this doesn't break when Batteries updates its Lean version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Batteries updates will not break the code in this book until a
lake update
is manually performed.This is not a problem, as any updates to Batteries should eventually be followed.