sort min_imports alphabetically #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there is a call to `qsort` it seems like sorting is intended here. However, currently `qsort` is called on `Name`, but apparently this does not do the correct thing, since when using this in mathlib, I observed that the output was not sorted. We fix this by converting to string earlier and using the `(· < ·)` function to compare the strings.
|
friendly pinging @semorrison, because I'm not sure my pull request was seen... |
|
I think the underlying issue is that the sorting on Could we first have a Lean Issue about this? Or confirmation that this is working as intended? This happens because Name.cmp does the following:
|
3 tasks
|
If leanprover/lean4#4944 is not addressed or found invalid, then your fix here is the correct thing to do. Let's give them some time to look at the issue. |
|
SGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is a call to
qsortit seems like sorting is intended here. However, currentlyqsortis called onName, but apparently this does not do the correct thing, since when using this in mathlib, I observed that the output was not sorted. We fix this by converting to string earlier and using the(· < ·)function to compare the strings.