Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying suggestions with InteractiveCode widget #1

Closed
wants to merge 3 commits into from

Conversation

0art0
Copy link

@0art0 0art0 commented Sep 11, 2024

leansearch_interactivecode_demo

This PR displays the suggestions from Lean Search as clickable and hoverable expressions in the infoview.

@siddhartha-gadgil
Copy link
Collaborator

  • From the picture it looks like this is not a "TryThis", so one cannot click or use a code action and replace. Is that correct.
  • Also having the types displayed straightaway (as in the current code) is more convenient for a user than having to click.

If I am right about the above they are serious regressions and not worth it for a feature that certainly looks nice but it is not clear how much it helps users in their task of finding results.

@0art0
Copy link
Author

0art0 commented Sep 11, 2024

Yes, that is correct. Functionality for text replacement on clicking can be added, but it's likely that it will interfere with the hovering functionality.

@siddhartha-gadgil
Copy link
Collaborator

Yes, that is correct. Functionality for text replacement on clicking can be added, but it's likely that it will interfere with the hovering functionality.

In that case I am closing this PR. In my view text replacement is something users will want more than hovering before selection.

It would be good to give users choice with multiple commands (or some configuration). But since the additional dependency complicates the use of the present syntax, I suggest you have a different repository with the other format and its use can be discussed separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants