Fix static check issues

cmd/poe_options_selector.go

@@ -153,7 +153,7 @@ func prefixFromTemplateFileName(templateFile string) (string, error) {
 
 	return "", errors.New(
 		"invalid template-arb-file. Should be a filename with prefix ending " +
-			"with an underscore followed by a valid BCP-47 locale.",
+			"with an underscore followed by a valid BCP-47 locale",
 	)
 }
 

cmd/seed.go

@@ -98,7 +98,7 @@ func runSeed(cmd *cobra.Command, args []string) error {
 		var b bytes.Buffer
 		flutterLocale, err := converter.Convert(&b)
 		if err != nil {
-			if errors.Is(err, arb2poe.NoTermsError) {
+			if errors.Is(err, arb2poe.ErrNoTerms) {
 				fileLog.Info("no terms to convert")
 				continue
 			}

cmd/version.go

@@ -52,11 +52,12 @@ func getVcsInfo() (revision, time string, modified bool, err error) {
 	}
 
 	for _, setting := range info.Settings {
-		if setting.Key == "vcs.revision" {
+		switch setting.Key {
+		case "vcs.revision":
 			revision = setting.Value
-		} else if setting.Key == "vcs.time" {
+		case "vcs.time":
 			time = setting.Value
-		} else if setting.Key == "vcs.modified" {
+		case "vcs.modified":
 			modified = setting.Value == "true"
 		}
 	}

convert/arb2poe/converter.go

@@ -26,7 +26,7 @@ func NewConverter(input io.Reader, templateLocale flutter.Locale, termPrefix str
 	}
 }
 
-var NoTermsError = errors.New("no terms to convert")
+var ErrNoTerms = errors.New("no terms to convert")
 
 func (c *Converter) Convert(output io.Writer) (lang flutter.Locale, err error) {
 	lang, messages, err := parseARB(c.input)
@@ -47,7 +47,7 @@ func (c *Converter) Convert(output io.Writer) (lang flutter.Locale, err error) {
 	}
 
 	if len(poeTerms) == 0 {
-		return flutter.Locale{}, NoTermsError
+		return flutter.Locale{}, ErrNoTerms
 	}
 
 	err = json.NewEncoder(output).Encode(poeTerms)