Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3 #132

Draft
wants to merge 46 commits into
base: master
Choose a base branch
from
Draft

Version 3 #132

wants to merge 46 commits into from

Conversation

joelgallant
Copy link
Contributor

@joelgallant joelgallant commented Apr 9, 2021

Closes #130

  • Provide a better mechanism for "skipping double runs" of the same extension
  • Bundle the "environment options trio" type
  • Extension utils for getEnv, etc.
  • Remove default-extensions
  • Documentation updates
  • Exploring "lazy option validation" improvements
  • Use composeExtensions in config loading to prove robustness
  • Remove Node.js v10 support

Will depend on #134, #135, #136

@cypress
Copy link

cypress bot commented Apr 9, 2021



Test summary

21 0 0 0


Run details

Project App Config
Status Passed
Commit a3a4e96
Started Sep 27, 2021 12:32 AM
Ended Sep 27, 2021 12:34 AM
Duration 02:17 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov-io
Copy link

codecov-io commented Apr 10, 2021

Codecov Report

Merging #132 (c0995d8) into master (e697635) will decrease coverage by 0.15%.
The diff coverage is 94.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   79.59%   79.43%   -0.16%     
==========================================
  Files          32       32              
  Lines        2220     2208      -12     
  Branches      529      527       -2     
==========================================
- Hits         1767     1754      -13     
- Misses        453      454       +1     
Impacted Files Coverage Δ
app-config-cli/src/validation.ts 13.51% <0.00%> (ø)
app-config-main/src/index.ts 93.75% <ø> (-1.32%) ⬇️
app-config-core/src/parsed-value.ts 82.07% <85.71%> (-0.48%) ⬇️
app-config-extensions/src/index.ts 95.06% <94.54%> (+0.10%) ⬆️
app-config-config/src/index.ts 96.59% <100.00%> (ø)
app-config-core/src/config-source.ts 69.60% <100.00%> (+0.24%) ⬆️
app-config-extension-utils/src/index.ts 95.45% <100.00%> (ø)
app-config-node/src/file-source.ts 84.90% <100.00%> (ø)
app-config-schema/src/index.ts 90.00% <100.00%> (-0.10%) ⬇️
app-config-v1-compat/src/index.ts 58.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f97b302...c0995d8. Read the comment docs.

@@ -22,150 +22,175 @@ jobs:
token: ${{ secrets.NPM_TOKEN }}
access: public
package: ./app-config-config/package.json
tag: next
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove before merging

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #132 (a3a4e96) into master (c17d97e) will decrease coverage by 0.29%.
The diff coverage is 92.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   80.10%   79.80%   -0.30%     
==========================================
  Files          42       42              
  Lines        2498     2392     -106     
  Branches      605      559      -46     
==========================================
- Hits         2001     1909      -92     
+ Misses        497      483      -14     
Impacted Files Coverage Δ
app-config-cli/src/validation.ts 13.51% <0.00%> (ø)
app-config-extensions/src/env-var-directive.ts 100.00% <ø> (ø)
app-config-git/src/index.ts 63.88% <ø> (+1.38%) ⬆️
app-config-main/src/index.ts 93.75% <ø> (-1.32%) ⬇️
app-config-extensions/src/index.ts 75.67% <89.28%> (+5.67%) ⬆️
app-config-config/src/index.ts 96.62% <100.00%> (-0.08%) ⬇️
app-config-core/src/parsed-value.ts 82.56% <100.00%> (ø)
app-config-encryption/src/index.ts 100.00% <100.00%> (+6.25%) ⬆️
app-config-extension-utils/src/index.ts 92.45% <100.00%> (ø)
app-config-extensions/src/substitute-directive.ts 96.66% <100.00%> (-1.16%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17d97e...a3a4e96. Read the comment docs.

@cypress
Copy link

cypress bot commented Sep 26, 2021



Test summary

21 0 0 0


Run details

Project App Config
Status Passed
Commit 0e53709 ℹ️
Started Sep 27, 2021 12:34 AM
Ended Sep 27, 2021 12:36 AM
Duration 02:46 💡
OS Linux Ubuntu - 20.04
Browser Electron 87

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 3 Changes
3 participants