You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On one hand Checks API provides some means to make detailed reports with comments on particular lines of sources. So when the formatting check fails, it could generate a diff and comment on the pieces of the mis-formatted code.
On the other hand I personally don't see much value in such detailed reports. I would prefer the check to fail on the first mis-formatted file and report immediately, so that the feedback would be quick. I think that in most cases you don't care what exactly was mis-formatted, you just forgot to do it and as soon as you got this reminder on GitHub, you can just run scalafmt locally (in whatever preferred way) and fix it.
It could be a configuration option, but I would like to avoid a bot-specific configuration and even if there was one, I want to choose a sensible default.
The text was updated successfully, but these errors were encountered:
On one hand Checks API provides some means to make detailed reports with comments on particular lines of sources. So when the formatting check fails, it could generate a diff and comment on the pieces of the mis-formatted code.
On the other hand I personally don't see much value in such detailed reports. I would prefer the check to fail on the first mis-formatted file and report immediately, so that the feedback would be quick. I think that in most cases you don't care what exactly was mis-formatted, you just forgot to do it and as soon as you got this reminder on GitHub, you can just run
scalafmt
locally (in whatever preferred way) and fix it.It could be a configuration option, but I would like to avoid a bot-specific configuration and even if there was one, I want to choose a sensible default.
The text was updated successfully, but these errors were encountered: