New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions #3

Open

laughedelic opened this issue Jun 1, 2018 · 1 comment

Labels

discussion

Owner

laughedelic commented Jun 1, 2018

Here are some ideas for the possible actions:

when there's no .scalafmt.conf, cancel the check and offer an action to add an empty config
when the check fails, offer an action to commit fixed formatting
fail-fast by default, but offer an action to run the full check with a detailed report (see Fail-fast behaviour vs. detailed reports #1)

I think that interactiveness is great, but I don't like that it forces the user to give write permissions to all repos where they install this app.

The text was updated successfully, but these errors were encountered:

laughedelic added the discussion label

Owner Author

laughedelic commented Jun 3, 2018

once a check run is queued/in-progress, add an action button to cancel it (this requires querying check run status while processing data and having escape hatches to be able to stop a running check)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment