Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy stub returns a nullable boolean to support fallthrough #54069

Closed
wants to merge 1 commit into from

Conversation

Roboroads
Copy link

@Roboroads Roboroads commented Jan 3, 2025

This is a non-breaking, minor change to the policy stubs. Since a policy can also return null to support a fallthrough Gate::after.

@Roboroads Roboroads changed the title Policy stub returns a nullable boolean to support for fallthrough Policy stub returns a nullable boolean to support fallthrough Jan 3, 2025
@taylorotwell
Copy link
Member

I think that's fairly uncommon. If you have an policy method that does that you can just update the type hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants