[8.x] Behaviour change on assertAttributeDoesntContain (#1154)

* Update MakesAssertions.php * Update MakesAssertions.php revert changes on wrong place and add correct changes * Update MakesAssertions.php remove whitespace * Update MakesAssertionsTest.php Update test_assert_attribute_does_not_contain to reflect new behaviour. * Update MakesAssertions.php remove whitespace
laravel · Jan 6, 2025 · 8ddd53a · 8ddd53a
1 parent 204151b
commit 8ddd53a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 15 deletions.
diff --git a/src/Concerns/MakesAssertions.php b/src/Concerns/MakesAssertions.php
@@ -827,14 +827,11 @@ public function assertAttributeContains($selector, $attribute, $value)
      */
     public function assertAttributeDoesntContain($selector, $attribute, $value)
     {
-        $fullSelector = $this->resolver->format($selector);
-
         $actual = $this->resolver->findOrFail($selector)->getAttribute($attribute);
 
-        PHPUnit::assertNotNull(
-            $actual,
-            "Did not see expected attribute [{$attribute}] within element [{$fullSelector}]."
-        );
+        if (is_null($actual)) {
+            return $this;
+        }
 
         PHPUnit::assertStringNotContainsString(
             $value,

diff --git a/tests/Unit/MakesAssertionsTest.php b/tests/Unit/MakesAssertionsTest.php
@@ -683,15 +683,7 @@ public function test_assert_attribute_does_not_contain()
 
         $browser->assertAttributeDoesntContain('foo', 'bar', 'class-c');
 
-        try {
-            $browser->assertAttributeDoesntContain('foo', 'bar', 'class-c');
-            $this->fail();
-        } catch (ExpectationFailedException $e) {
-            $this->assertStringContainsString(
-                'Did not see expected attribute [bar] within element [Foo].',
-                $e->getMessage()
-            );
-        }
+        $browser->assertAttributeDoesntContain('foo', 'bar', 'class-c');
 
         try {
             $browser->assertAttributeDoesntContain('foo', 'bar', 'class-1');