Fix create_signal_from_tokio_channel feature
#733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an apparent type error where a `Trigger` was being passed to `crate::ext_event::register_ext_trigger; instead of an `ExtSendTrigger`. It was under a feature flag and isn't used in any examples which is probably why it evaded detection.
|
I also tested this fix in a nontrivial project which uses |
jrmoulton
reviewed
Jan 14, 2025
|
This looks good (and yes was a bug) but I'm not sure I understand the reason for that trait |
jrmoulton
reviewed
Jan 14, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an apparent type error where a
Triggerwas being passed tocrate::ext_event::register_ext_trigger; instead of anExtSendTrigger`. It was under a feature flag and isn't used in any examples which is probably why it evaded detection.