Enhance checkbox customizability #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Checkbox` component now offers a greater degree of customizability over the appearance of the `checked` state. Previously, the checkmark was not customizable. Now, users may provide their own SVGs if they wish. No existing APIs were broken, but a few new ones were added, namely there's now a `custom_` prefixed static method for each existing method. Also, two new convenience functions, `custom_checkbox` and `custom_labeled_checkboxes` are available. The default checkbox SVG is now made available to users if they want to use it elsewhere, for example in a different component (previously it was a function-local `const`, now it's a `pub const`. The `checkbox` example in the `widget-gallery` has been enhanced with two additional examples showcasing some of the new behavior.
jrmoulton
requested changes
Jan 9, 2025
Apply the suggestions for the documentation of the `custom_` prefixed methods and helpers.
jrmoulton
approved these changes
Jan 9, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Checkboxcomponent now offers a greater degree of customizability over the appearance of thecheckedstate. Previously, the checkmark was not customizable. Now, users may provide their own SVGs if they wish. No existing APIs were broken, but a few new ones were added, namely there's now acustom_prefixed static method for each existing method. Also, two new convenience functions,custom_checkboxandcustom_labeled_checkboxare available. The default checkbox SVG is now made available to users if they want to use it elsewhere, for example in a different component (previously it was a function-localconst, now it's apub const).The
checkboxexample in thewidget-galleryhas been enhanced with two additional examples showcasing some of the new behavior. I've attached a screenshot of the new functionality below.