MAINT, TST: remove usage of test.support #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the `test` package in CPython is intended for internal use by the CPython development team only, and is subject to API changes without prior deprecation, as noted here: https://docs.python.org/3.11/library/test.html * `test.support.run_unittest` is not available in Python `3.11.7`, but is available in some other versions of `3.11.x` and `3.12.x`; clearly depending on that is not really sane, so let's just remove the usage--this allows the full test suite to pass for me locally with `3.11.7` * I don't think there was any good reason to keep those `test_main()` style blocks anyway--perhaps you can encourage developers to use `pytest path/to/test_module.py`, which will do the same thing (most/all OSS packages would suggest that at this point I think); if you have folks who were running the tests with `python path/to/test_module.py` they'd need to swap to using `pytest` for the incantation, but maybe that's something you can live with?
|
Thanks @tylerjereddy. I think I was using the mains way back when I first started this project to run the tests by hand. Given that pytest is the intended use case I don't see any reason not to remove these. Thanks for fixing this so quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to Check p11 #32 (comment) cc @clevelam
the
testpackage in CPython is intended for internal use by the CPython development team only, and is subject to API changes without prior deprecation, as noted here: https://docs.python.org/3.11/library/test.htmltest.support.run_unittestis not available in Python3.11.7, but is available in some other versions of3.11.xand3.12.x; clearly depending on that is not really sane, so let's just remove the usage--this allows the full test suite to pass for me locally with3.11.7I don't think there was any good reason to keep those
test_main()style blocks anyway--perhaps you can encourage developers to usepytest path/to/test_module.py, which will do the same thing (most/all OSS packages would suggest that at this point I think); if you have folks who were running the tests withpython path/to/test_module.pythey'd need to swap to usingpytestfor the incantation, but maybe that's something you can live with?