-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parallel File Parsing and Improve testing #31
Conversation
@tylerjereddy One more request. Would you be willing to review this Change set. Primarily I would like feedback on my multiprocessing implementation. I've found that this drastically speeds up the parsing for large number file sets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some initial comments/thoughts, a lot of it related to testing robustness to be confident in the parallel behavior.
I didn't try to check if the new functionality is actually faster, the community like using https://github.com/airspeed-velocity/asv for that, although this is quite formal so may be too much if you already have the performance envidence you need.
Thanks for the feedback @tylerjereddy I've significantly updated the testing and opened a couple of follow on issues. |
This enables parallel file processing for outputs, tallies, and dumps but default.