Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue984/switch to ruff #987

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Issue984/switch to ruff #987

wants to merge 13 commits into from

Conversation

Leahh02
Copy link
Collaborator

@Leahh02 Leahh02 commented Jan 10, 2025

This PR fixes issue #984.

This PR will be compared with PR #986 which switches to pylint so we can decide which one to switch to.

@Leahh02 Leahh02 added the WIP (lint-only) Only run the linter in CI, nothing else label Jan 10, 2025
@Leahh02
Copy link
Collaborator Author

Leahh02 commented Jan 10, 2025

This PR fixes issue #984.

This PR will be compared with PR #986 which switches to pylint so we can decide which one to switch to.

There are things that Ruff isn't picking up that I thought it would. For example, it's not picking up message E501, the line too long error, when it should be. This is because it's only checking rules sections ["E4", "E7", "E9", "F"] because that's the default for the select category of the configuration. We can add more sections to the select category or create a extend-select section to the configuration.

There are some message codes that I set to ignore in ruff.toml even though they are in "preview". It seems like "preview" is something they're working to introduce. I went ahead and added "preview" message codes into ruff.toml that were in setup.cfg so we'd have them there when they get added to a new release. These messages are PLR0914 and PLR0916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP (lint-only) Only run the linter in CI, nothing else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant