fix(js): remove default created_at from createExample method. #1406
+7
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #1399
Issue:
Examples created from the createExample method of the JS client are created with 3 digits of fractional seconds.
How Issue Presents:
The endpoint to get dataset versions (https://api.smith.langchain.com/api/v1/datasets/{dataset_id}/version) always responds with 6 digits of fractional seconds.
When filtering expirements by dataset ID the langsmith frontend will use one of the resuls from the get dataset verions i.e the timestamp with 6 digits.
When a expirement is being tagged with a dataset version it will use the modified_at key of an example which if created from the JS client will only contain 3 digits of precison.
Fix:
Hand over the creation of the createExample created_at timestamp to langsmith server.