Refactoring PDF loaders: 02 PyMuPDF #29063
Open
+2,174
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XXL
Add file_path with PurePath Add CloudBlobLoader in __init__ Replace Dict/List to dict/list
pprados
force-pushed
the
pprados/02-pymupdf
branch
from
039819c to
3beda82
Compare
|
@eyurtsev I rebase the code with master ;-) |
eyurtsev
reviewed
Jan 8, 2025
eyurtsev
reviewed
Jan 9, 2025
libs/community/langchain_community/document_loaders/parsers/pdf.py
Outdated
Show resolved
Hide resolved
| for k, v in metadata.items(): | ||
| if type(v) not in [str, int]: | ||
| v = str(v) | ||
| if k.startswith("/"): |
There was a problem hiding this comment.
bug? The file path could be an absolute path on the local machine -- this looks like an error right now?
There was a problem hiding this comment.
No, it's for the metadata key, not values. Some PDF parseur use key like /creationDate
libs/community/langchain_community/document_loaders/parsers/pdf.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/document_loaders/parsers/pdf.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/document_loaders/parsers/pdf.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/document_loaders/parsers/pdf.py
Outdated
Show resolved
Hide resolved
| @@ -78,6 +203,192 @@ def extract_from_images_with_rapidocr( | |||
| return text | |||
|
|
|||
|
|
|||
| # Type to change the function to convert images to text. | |||
| CONVERT_IMAGE_TO_TEXT = Optional[Callable[[Iterable[np.ndarray]], Iterator[str]]] | |||
There was a problem hiding this comment.
MAJOR:
Why not use an ImageBlobParser w/ the regular Blob to Document interface. it'll allow reusing the image logic for images that do not originate from pdfs (e.g., to re-use for a web crawler)
A PDF parser doesn't would accept a parser as part of the initializer
class PDFParser(...):
def __Init__(self, ... *, ..., image_blob_parser: Optional[BlobParser] = None):
passIf the image_pdf_parser is provided, then it'll be used for OCR purposes.
There was a problem hiding this comment.
I've done it! There are now 3 ImageBlogParsers!
pprados
force-pushed
the
pprados/02-pymupdf
branch
from
0d99673 to
3fe4ec5
Compare
pprados
force-pushed
the
pprados/02-pymupdf
branch
2 times, most recently
from
4342991 to
760267b
Compare
pprados
force-pushed
the
pprados/02-pymupdf
branch
3 times, most recently
from
9fc89e0 to
d30b26d
Compare
pprados
force-pushed
the
pprados/02-pymupdf
branch
2 times, most recently
from
6765dbf to
df1d4d5
Compare
pprados
force-pushed
the
pprados/02-pymupdf
branch
from
df1d4d5 to
91234f0
Compare
dosubot
bot
added
the
🤖:docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring PDF loaders step 2: "community: Refactoring PDF loaders to standardize approaches"
Description: Update PyMuPDFParser/Loader
Twitter handle: pprados
This is one part of a larger Pull Request (PR) that is too large to be submitted all at once.
This specific part focuses to prepare the update of all parsers.
For more details, see PR 28970.
@eyurtsev it's the continuation of PDFLoader modifications.