Support for Gemini Tool Calling and Correct usage metadata in ChatOpenAI #29002
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling Gemini via `ChatOpenAI` the `tool_calls` comes as `toolCalls` and metadata usage like `prompt_tokens` comes as `promptTokens`. So, to handle both the conditions, added an OR condition which will check whether the call has any of it.
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
🤖:nit
ccurme
reviewed
Jan 3, 2025
There was a problem hiding this comment.
What is the motivation for interacting with these models via ChatOpenAI instead of a google integration, such as langchain-google-vertexai?
|
@ccurme There was a functionality given by google to use openai package for gemini model and if there is support with openai package then why do we need another library such as langchain-google-vertexai. Please refer to below link provided by google - |
|
Hi @Gaggi72, this should now be fixed in Google's API. Could you please check? Can re-open if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, to handle both the conditions, added an OR condition which will check whether the call has any of it.
Thank you for contributing to LangChain!
Package: Langchain-openai
Description: Support for Gemini Tool Calling and Correct usage metadata in ChatOpenAI
Issue: When calling Gemini via
ChatOpenAIthetool_callscomes astoolCallsand metadata usage likeprompt_tokenscomes aspromptTokens.Dependencies: N/A