Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer versions of simsimd (<7.x) #213

Closed
wants to merge 1 commit into from

Conversation

graipher
Copy link

Fixes #212

Increase allowed version range for simsimd to allow for the current 6.x version. This should allow installing this package with Python 3.13.

@graipher
Copy link
Author

graipher commented Nov 22, 2024

Arguably, the Python version constraint should also be changed to python = ">=3.9,<3.14" to make it more explicit that any newer Python version is not automatically usable.

@tjmcdonough
Copy link

Can this be merged?

@graipher
Copy link
Author

graipher commented Dec 5, 2024

In my opinion yes, once the pipeline has succeeded after having been approved to run.

@hsm207
Copy link
Collaborator

hsm207 commented Dec 9, 2024

@graipher thank you for your contribution! This has been taken care in PR #214 so I'll go ahead and close this one.

Sorry I missed your PR earlier. I was cleaning up the codebase and missed this.

Appreciate your effort though!

@hsm207 hsm207 closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install on Python 3.13
3 participants