Updating cookie-parsing regex to be more aligned with RFC 6265 #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: denis.yuryev <[email protected]>
check24-denis
force-pushed
the
cookie-parsing-regex-update
branch
from
ff53764 to
d147c63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regex inside
parseCookieHeaderis not totally in alignment with RFC 6265. This PR aims to fix two moments:test1=test;test2=test. Previously this led to an empty cookie array (or in versions less than3.*to a fallback using$_COOKIEarray).test[test1]=test; test[test2]=test2. This should solve an exissting issue, I believe: Array cookies not parser properly #7.I've added tests for these cases.