fix(eigen-client-extra-features): address comments #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianbelinche
reviewed
Jan 7, 2025
| @@ -30,7 +32,7 @@ impl Default for EigenConfig { | |||
| disperser_rpc: "https://disperser-holesky.eigenda.xyz:443".to_string(), | |||
| settlement_layer_confirmation_depth: 0, | |||
| eigenda_eth_rpc: Some("https://ethereum-holesky-rpc.publicnode.com".to_string()), | |||
| eigenda_svc_manager_address: "0xD4A7E1Bd8015057293f0D0A557088c286942e84b".to_string(), | |||
| eigenda_svc_manager_address: H160::from_str("0xD4A7E1Bd8015057293f0D0A557088c286942e84b").unwrap(), | |||
There was a problem hiding this comment.
Maybe avoid the unwrap, with an unwrap_or and a H160::zero maybe
gianbelinche
approved these changes
Jan 7, 2025
juanbono
reviewed
Jan 8, 2025
| pub enum VerificationError { | ||
| #[error("Service manager error")] | ||
| ServiceManagerError, |
There was a problem hiding this comment.
is there a way to include the service manager error here?
juanbono
reviewed
Jan 8, 2025
| DifferentHashes, | ||
| #[error("Different hashes: expected {expected:?}, got {actual:?}")] | ||
| DifferentHashes { expected: String, actual: String }, | ||
| #[error("Wrong quorum params")] | ||
| WrongQuorumParams, |
There was a problem hiding this comment.
is there a way to know which params are wrong?
There was a problem hiding this comment.
Yes! I have modified the error so it shows them.
juanbono
reviewed
Jan 8, 2025
| #[error("Link Error: {0}")] | ||
| LinkError(String), | ||
| #[error(transparent)] | ||
| JoinError(#[from] tokio::task::JoinError), |
There was a problem hiding this comment.
I think we should map the join error to a different and existing error variant instead of adding it to the VerificationError
juanbono
reviewed
Jan 8, 2025
| @@ -30,7 +32,7 @@ impl Default for EigenConfig { | |||
| disperser_rpc: "https://disperser-holesky.eigenda.xyz:443".to_string(), | |||
| settlement_layer_confirmation_depth: 0, | |||
| eigenda_eth_rpc: Some("https://ethereum-holesky-rpc.publicnode.com".to_string()), | |||
| eigenda_svc_manager_address: "0xD4A7E1Bd8015057293f0D0A557088c286942e84b".to_string(), | |||
| eigenda_svc_manager_address: H160::from_str("0xD4A7E1Bd8015057293f0D0A557088c286942e84b").unwrap_or_default(), | |||
There was a problem hiding this comment.
please move this to a constant and specify what contract it is (EigenDA service manager in Holesky)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Attemp to resolve all comments left after last round of reviews of
extra-featuresPR.Why ❔
Checklist
zkstack dev fmtandzkstack dev lint.