Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use Deployment selector for create-default-pdb #786

Merged
merged 1 commit into from
Dec 2, 2023
Merged

fix: Use Deployment selector for create-default-pdb #786

merged 1 commit into from
Dec 2, 2023

Conversation

mikebryant
Copy link
Contributor

Related Issue(s)

Fixes #785

Description

Copies the Deployment selector into the PDB, instead of assuming the Pod and Deployment labels will be the same

Checklist

  • [] I have read the policy contribution guidelines.
  • [] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • [] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

chipzoller
chipzoller approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah crap, thanks for catching that. Will wait for tests to succeed.

@chipzoller chipzoller merged commit 92fd58e into kyverno:main Dec 2, 2023
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipzoller chipzoller chipzoller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] create-default-pdb uses labels of triggering object rather than selector
2 participants
@mikebryant @chipzoller