Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pod security standards (baseline) in CEL expressions - Part 2 #775

Merged
merged 3 commits into from
Nov 8, 2023
Merged

feat: add pod security standards (baseline) in CEL expressions - Part 2 #775

merged 3 commits into from
Nov 8, 2023

Conversation

MariamFahmy98
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 commented Oct 2, 2023 •
edited
Loading

Related Issue(s)

#773

Description

This PR adds Kyverno policies written in CEL expressions for pod security standards (baseline).

Checklist

  • I have read the policy contribution guidelines.
  • I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

@MariamFahmy98 MariamFahmy98 changed the title feat: add pod security standards (baseline) in CEL expressions feat: add pod security standards (baseline) in CEL expressions - Part 2 Oct 2, 2023
@chipzoller chipzoller self-requested a review October 26, 2023 14:10
@chipzoller
Copy link
Contributor

Per Slack discussion, if validate.message does not work currently for CEL expression Kyverno policies, the field should be removed.

@MariamFahmy98 MariamFahmy98 force-pushed the pod-security-cel-part-2 branch from 0566ff1 to 5bf1775 Compare November 7, 2023 11:55
@chipzoller
Copy link
Contributor

Conflicts, @MariamFahmy98

@MariamFahmy98 MariamFahmy98 force-pushed the pod-security-cel-part-2 branch from 09aac0b to 5d361b6 Compare November 8, 2023 14:22
chipzoller
chipzoller approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chipzoller chipzoller merged commit 099c8c8 into kyverno:main Nov 8, 2023
116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipzoller chipzoller chipzoller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MariamFahmy98 @chipzoller