Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pod security standards (baseline) in CEL expressions - Part 1 #772

Merged
merged 8 commits into from
Nov 8, 2023

Conversation

MariamFahmy98
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 commented Sep 28, 2023

Related Issue(s)

#773

Description

This PR adds Kyverno policies written in CEL expressions for pod security standards (baseline).
note: I will distribute the work on multiple PRs to make the review process a little bit easier.

Checklist

  • I have read the policy contribution guidelines.
  • I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

@MariamFahmy98 MariamFahmy98 force-pushed the pod-security-cel-policies branch 3 times, most recently from ee1a4c6 to 963e623 Compare September 28, 2023 17:28
Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kyverno.io/kubernetes-version version for these state 1.22-1.23. As you know, this is the version of Kubernetes on which the policies were tested and certified to work. Except these versions are rather old at this point. Can you please retest on something like 1.26-1.27?

@MariamFahmy98 MariamFahmy98 changed the title feat: add pod security standards (baseline) in CEL expressions feat: add pod security standards (baseline) in CEL expressions - Part 1 Oct 1, 2023
@chipzoller
Copy link
Contributor

Per Slack discussion, if validate.message does not work currently for CEL expression Kyverno policies, the field should be removed.

@MariamFahmy98 MariamFahmy98 force-pushed the pod-security-cel-policies branch from 63c40e8 to 6d78cb9 Compare November 7, 2023 11:42
Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great work!

@chipzoller chipzoller merged commit 9f6fc1c into kyverno:main Nov 8, 2023
116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants