Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Introduce versions.yaml file #2172

Merged
merged 21 commits into from
Jan 14, 2025
Merged

chore: Introduce versions.yaml file #2172

merged 21 commits into from
Jan 14, 2025

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Jan 13, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • introduces a versions.yaml which centrally defines tooling versions to be used in the project
  • versions defined in the yaml are re-used in
    • E2E tests
    • local scripts
    • VS code tasks
    • Makefile

Reasons

  • one source of truth for tooling versions

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner January 13, 2025 14:11
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 13, 2025
@c-pius c-pius added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jan 13, 2025
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 13, 2025
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 13, 2025
@c-pius c-pius requested a review from a team as a code owner January 13, 2025 14:47
@lindnerby lindnerby self-assigned this Jan 14, 2025
@c-pius c-pius removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
@lindnerby lindnerby enabled auto-merge (squash) January 14, 2025 09:14
lindnerby
lindnerby previously approved these changes Jan 14, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 14, 2025
mmitoraj
mmitoraj reviewed Jan 14, 2025
View reviewed changes
docs/contributor/04-local-test-setup.md Outdated Show resolved Hide resolved
scripts/tests/README.md Outdated Show resolved Hide resolved
@c-pius @mmitoraj
Apply suggestions from code review
fc0234c 
Co-authored-by: Małgorzata Świeca <[email protected]>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 14, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 14, 2025
@lindnerby lindnerby merged commit 701417f into kyma-project:main Jan 14, 2025
68 checks passed
@c-pius c-pius deleted the chore/introduce-versions-file branch January 14, 2025 12:07
@c-pius c-pius assigned c-pius and unassigned mmitoraj and lindnerby Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindnerby lindnerby lindnerby approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

Assignees

@c-pius c-pius

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@c-pius @mmitoraj @lindnerby @kyma-bot