Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fill existing resourceVersion if not provided for updates #3587

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fill existing resourceVersion if not provided for updates #3587

wants to merge 1 commit into from

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Jan 14, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • if a resource is updated, but no metadata.resourceVersion is provided, the PATCH request sent to the Kubernetes server thus attempts to remove the resourceVersion field from the resource, which leads to an error. To fix it the metadata.resourceVersion will be filled with the corresponding value of the existing resource.

Related issue(s)
#3327

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2025
@chriskari chriskari linked an issue Jan 14, 2025 that may be closed by this pull request
Editing the resource from Upload YAML is not working #3327
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@akucharska akucharska

Labels
cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editing the resource from Upload YAML is not working
3 participants
@chriskari @akucharska @kyma-bot