Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose Monaco and Dynamic Page as Web Components #3579

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: expose Monaco and Dynamic Page as Web Components #3579

wants to merge 8 commits into from

Conversation

OliwiaGowor
Copy link
Contributor

@OliwiaGowor OliwiaGowor commented Jan 13, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • added a generic function for creating Web Components
  • added Monaco Editor Web Component
  • added Dynamic Page Web Component
  • added documentation for Web Components

Related issue(s)
Closes #3520

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 13, 2025
@OliwiaGowor OliwiaGowor marked this pull request as ready for review January 13, 2025 06:41
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskari chriskari chriskari approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@pbochynski pbochynski

@chriskari chriskari

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose Monaco Code Editor as a Web Component for Custom Extensions
4 participants
@OliwiaGowor @chriskari @pbochynski @kyma-bot