Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: uxc tables improvements #3118

Merged
merged 10 commits into from
Aug 14, 2024
Merged

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Aug 9, 2024

Description

Changes proposed in this pull request:

  • Protected resource icon is clickable and opens a popover instead of the tooltip on hover interaction
  • Protected resource icon in the table is now right next to the name instead of in a separate column
  • removed spacing after last table item
  • ClusterList: entire row is now navigateable, removed UI5link from name cell
  • text in TableRows can now be selected without executing the onClick
  • adjusted tests

Related issue(s)
#3011

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 9, 2024
@chriskari chriskari linked an issue Aug 9, 2024 that may be closed by this pull request
5 tasks
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 9, 2024
@OliwiaGowor OliwiaGowor self-assigned this Aug 14, 2024
OliwiaGowor
OliwiaGowor previously approved these changes Aug 14, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 14, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 14, 2024
@chriskari
Copy link
Contributor Author

/test pull-busola-web-build

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 14, 2024
@kyma-bot kyma-bot merged commit c1050c0 into kyma-project:main Aug 14, 2024
13 checks passed
@chriskari chriskari deleted the uxc-tables branch October 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UXC: Tables
3 participants