Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add badge for overriden channel #3090

Merged
merged 3 commits into from
Jul 22, 2024
Merged

feat: add badge for overriden channel #3090

merged 3 commits into from
Jul 22, 2024

Conversation

mrCherry97
Copy link
Contributor

@mrCherry97 mrCherry97 commented Jul 19, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • feat: add badge for overriden channel
  • fix: add beta to translations

Related issue(s)
Closes #3080

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2024
@mrCherry97 mrCherry97 marked this pull request as ready for review July 19, 2024 13:48
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 22, 2024
@kyma-bot kyma-bot merged commit 1e466ba into kyma-project:main Jul 22, 2024
19 of 20 checks passed
@mrCherry97 mrCherry97 deleted the overriden-channel branch July 22, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@valentinvieriu valentinvieriu Awaiting requested review from valentinvieriu

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@mmitoraj mmitoraj

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modules: Information about override channel on the modules list
4 participants
@mrCherry97 @kyma-bot @mmitoraj @OliwiaGowor