-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGINX: Bump to OpenResty v1.27.1.1. #12229
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
07a5d00
to
6d1e53c
Compare
6d1e53c
to
8e1b550
Compare
b4e6d09
to
e218096
Compare
/triage accepted |
need to bump the version TAG as well https://github.com/kubernetes/ingress-nginx/blob/main/images/nginx/TAG |
That's how CI will start the build https://github.com/kubernetes/ingress-nginx/blob/main/.github/workflows/zz-tmpl-images.yaml#L41 |
/kind feature |
I'm aware of that. But the container also builds if any file of the image changes: https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/k8s-staging-ingress-nginx.yaml#L177. So there is no need to bump the TAG, which's content should be decided by the ones forging the release, in this PR here. Anyway, I hope I find some time to review it in the next days. Sorry for that! |
@longwuyuan please bump the TAG file at least to start the test build, we can figure out cloud-build after it. Once the build passes, worst case we can revert before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to bump the TAG. Cloud Build is configured to trigger on any change in the whole directory, not just the TAG. Bumping the TAG to a proper version we then use in the NGINX_BASE is part of the release process, not part of development.
Also please do not merge this before we sorted v1.12 as we might build the NGINX base image from main
and then populate everything to the other branches. With this PR merged before the v1.12 release, the base image will include unwanted changes.
/hold
@Gacko the e2e tests runs with the new image when the TAG is bumped. I am not saying to merge, but I want to see the test passing |
This patch is very important to land, to enable the security of ingress-nginx installations, given that nginx 1.25 is EOL. What will it take to land it? |
We have spent the last few weeks debugging the nginx build in cloud build that was broken. We just got it working today. So we can start adding in PRs like this one. So soon. And most likely in 1.13. |
What's the current status of this PR? Looks like the CI is working well. |
We had to solve the before mentioned issues and release v1.12 first. With that done, I'm currently working on merging PRs like this one in a proper order. |
e0ddd45
to
f69d048
Compare
I extracted the ModSecurity bumps into this PR: #12641. So this PR here needs to be rebased on top of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
/kind feature
/priority backlog
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, longwuyuan, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
fixes #12170
How Has This Been Tested?
make
in the /images/nginx directory, on local clone"FOCUS=GRPC make kind-e2e-test"
. It passed"make kind-e2e-test
Checklist:
cc @rikatz @tao12345666333 @strongjz @Gacko