Remove controller runtime dependency #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xudong Liu <[email protected]>
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XudongLiuHarold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: Xudong Liu <[email protected]>
XudongLiuHarold
force-pushed
the
remove-controller-runtime-dependency
branch
from
d6d4f9e to
bb8c76e
Compare
Signed-off-by: Xudong Liu <[email protected]>
XudongLiuHarold
force-pushed
the
remove-controller-runtime-dependency
branch
2 times, most recently
from
1136300 to
0915a50
Compare
Signed-off-by: Xudong Liu <[email protected]>
XudongLiuHarold
force-pushed
the
remove-controller-runtime-dependency
branch
2 times, most recently
from
58e7427 to
503ec08
Compare
k8s-ci-robot
added
size/XL
XudongLiuHarold
force-pushed
the
remove-controller-runtime-dependency
branch
2 times, most recently
from
9699897 to
c624418
Compare
Signed-off-by: Xudong Liu <[email protected]>
XudongLiuHarold
force-pushed
the
remove-controller-runtime-dependency
branch
from
c624418 to
37441be
Compare
Signed-off-by: Xudong Liu <[email protected]>
XudongLiuHarold
force-pushed
the
remove-controller-runtime-dependency
branch
from
753b98b to
7cc41d5
Compare
DanielXiao
reviewed
Jan 31, 2024
DanielXiao
reviewed
Jan 31, 2024
|
|
||
| func (v *virtualMachineServices) Get(ctx context.Context, name string, opts v1.GetOptions) (*vmopv1alpha1.VirtualMachineService, error) { | ||
| virtualMachineService := &vmopv1alpha1.VirtualMachineService{} | ||
| if obj, err := v.client.Resource(VirtualMachineServiceGVR).Namespace(v.ns).Get(ctx, name, opts); err != nil { |
There was a problem hiding this comment.
I will create an feature request to use dynamic informer for get and list.
There was a problem hiding this comment.
Since we don't need to watch virtualmachine & virtualmachineservcie resources, we may not need informer and lister here?
There was a problem hiding this comment.
It depends on how frequently get/list is called. In general, a controller should call get/list from cache to reduce API calls on kube-apiserver even it does not watch those resources. Controller-runtime by default add the resource to informer cache at the first time get/list is called.
There was a problem hiding this comment.
I see! Yeah, we need a follow-up for this, thanks @DanielXiao !
DanielXiao
reviewed
Jan 31, 2024
|
@XudongLiuHarold Thanks and this is great. I would also invite @sbueringer @chrischdi to take a look. |
Signed-off-by: Xudong Liu <[email protected]>
k8s-ci-robot
removed
the
size/XL
k8s-ci-robot
added
the
size/XXL
XudongLiuHarold
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
XudongLiuHarold
force-pushed
the
remove-controller-runtime-dependency
branch
from
017bdc7 to
d861bcd
Compare
|
/retest |
|
I'll try to find time tomorrow to take a look |
sbueringer
reviewed
Feb 1, 2024
pkg/cloudprovider/vsphereparavirtual/vmoperator/client/virtualmachine_client_test.go
Outdated
Show resolved
Hide resolved
pkg/cloudprovider/vsphereparavirtual/vmoperator/client/virtualmachine_client_test.go
Outdated
Show resolved
Hide resolved
pkg/cloudprovider/vsphereparavirtual/vmoperator/client/virtualmachine_client_test.go
Show resolved
Hide resolved
Signed-off-by: Xudong Liu <[email protected]>
XudongLiuHarold
force-pushed
the
remove-controller-runtime-dependency
branch
from
d861bcd to
1006123
Compare
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged):fixes #840
Special notes for your reviewer:
Release note: