-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When moving to new sub, the name of the keyvault changed #459
When moving to new sub, the name of the keyvault changed #459
Conversation
Signed-off-by: James Sturtevant <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like we missed a few things when moving to the new sub, will be getting those into the new terraform scripts and will re-run this here |
/test pull-e2e-capz-windows-2022-extension-gmsa |
made it further, looks like we need another permission:
|
I think we are missing the permissions from windows-testing/capz/gmsa/setup-gmsa.sh Lines 113 to 114 in ccb4060
|
/test pull-e2e-capz-windows-2022-extension-gmsa |
3 similar comments
/test pull-e2e-capz-windows-2022-extension-gmsa |
/test pull-e2e-capz-windows-2022-extension-gmsa |
/test pull-e2e-capz-windows-2022-extension-gmsa |
gMSA tests pass! |
thanks! Somewhere in the scripts we are getting the wrong subscription context, debugging that then this will be ready. |
/test pull-e2e-capz-windows-2022-extension |
1 similar comment
/test pull-e2e-capz-windows-2022-extension |
/test pull-e2e-capz-windows-2022-extension-gmsa |
/test pull-e2e-capz-windows-2022-extension |
/test pull-e2e-capz-windows-2022-extension-gmsa |
472f4d9
to
69cc028
Compare
69cc028
to
e5c74b1
Compare
e5c74b1
to
a7dbf48
Compare
Signed-off-by: James Sturtevant <[email protected]>
a7dbf48
to
f171cf8
Compare
/test pull-e2e-capz-windows-2022-extension-gmsa |
1 similar comment
/test pull-e2e-capz-windows-2022-extension-gmsa |
/lgtm |
This updates to use the new keyvault name
capz-ci-gmsa-community
/assign @ritikaguptams