Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When moving to new sub, the name of the keyvault changed #459

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

jsturtevant
Copy link
Contributor

This updates to use the new keyvault name capz-ci-gmsa-community

/assign @ritikaguptams

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2024
@jsturtevant
Copy link
Contributor Author

Looks like we missed a few things when moving to the new sub, will be getting those into the new terraform scripts and will re-run this here

@ritikaguptams
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-gmsa

@jsturtevant
Copy link
Contributor Author

made it further, looks like we need another permission:

INFO: Getting the gmsa gmsaSpecFile gmsa-cred-spec-gmsa-e2e-22305 from https://capz-ci-gmsa-community.vault.azure.net
INFO: error when retrieving gmsaSpecFile GET https://capz-ci-gmsa-community.vault.azure.net/secrets/gmsa-cred-spec-gmsa-e2e-22305/
--------------------------------------------------------------------------------
RESPONSE 403: 403 Forbidden
ERROR CODE: Forbidden
--------------------------------------------------------------------------------
{
  "error": {
    "code": "Forbidden",
    "message": "The user, group or application 'appid=34d8e06d-d198-477e-b166-6936e58d90ae;oid=8eb97873-17bb-46a5-aed9-1967d83ca7ca;iss=https://sts.windows.net/d1aa7522-0959-442e-80ee-8c4f7fb4c184/' does not have secrets get permission on key vault 'capz-ci-gmsa-community;location=eastus'. For help resolving this issue, please see https://go.microsoft.com/fwlink/?linkid=2125287",
    "innererror": {
      "code": "AccessDenied"
    }
  }
}
-------

@jsturtevant
Copy link
Contributor Author

I think we are missing the permissions from

ciSP=$(az ad sp show --id "$CI_CLIENT_ID" --query id -o tsv)
az keyvault set-policy --name "${GMSA_KEYVAULT}" --object-id "$ciSP" --secret-permissions get delete list purge

@ritikaguptams
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-gmsa

3 similar comments
@ritikaguptams
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-gmsa

@ritikaguptams
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-gmsa

@ritikaguptams
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension-gmsa

@ritikaguptams
Copy link
Contributor

ritikaguptams commented Jul 30, 2024

gMSA tests pass!
Infra PR to have the right role assignments wired up: kubernetes/k8s.io#7101

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 30, 2024
@jsturtevant
Copy link
Contributor Author

jsturtevant commented Jul 30, 2024

gMSA tests pass! Infra PR to have the right role assignments wired up: kubernetes/k8s.io#7101

thanks! Somewhere in the scripts we are getting the wrong subscription context, debugging that then this will be ready.

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension

1 similar comment
@ritikaguptams
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-gmsa

capz/run-capz-e2e.sh Outdated Show resolved Hide resolved
@ritikaguptams
Copy link
Contributor

/test pull-e2e-capz-windows-2022-extension

@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-gmsa

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 31, 2024
Signed-off-by: James Sturtevant <[email protected]>
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-gmsa

1 similar comment
@jsturtevant
Copy link
Contributor Author

/test pull-e2e-capz-windows-2022-extension-gmsa

@ritikaguptams
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit 200e37d into kubernetes-sigs:master Jul 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants