Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add e2e test setup for GCP provider #1701

Merged
merged 1 commit into from
Jan 10, 2025
Merged

test: add e2e test setup for GCP provider #1701

merged 1 commit into from
Jan 10, 2025
+109 −2

Conversation

dargudear-google
Copy link
Contributor

@dargudear-google dargudear-google commented Dec 5, 2024 •
edited
Loading

What type of PR is this?

/kind failing-test

What this PR does / why we need it: Runs e2e test for driver with gcp provider

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1583

Special notes for your reviewer:
Earlier gcp tests were using hardcoded static secrets from google owned project. Now this PR uses secrets freshly created on boskos project.

TODOs:

  • squashed commits
  • includes documentation

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dargudear-google. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

@dargudear-google: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-secrets-store-csi-driver-e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2024
@aramase
Copy link
Member

aramase commented Dec 6, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2024
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

2 similar comments
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2024
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

4 similar comments
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

1 similar comment
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

1 similar comment
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google dargudear-google force-pushed the provider-gcp-test branch 3 times, most recently from a9f26b6 to ff90da3 Compare January 9, 2025 05:39
@dargudear-google dargudear-google changed the title TEST: GCP e2e test E2E test for GCP provider Jan 9, 2025
@dargudear-google dargudear-google marked this pull request as ready for review January 9, 2025 07:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2025
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

1 similar comment
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@aramase
Copy link
Member

aramase commented Jan 9, 2025

/retitle test: add e2e test setup for GCP provider

@k8s-ci-robot k8s-ci-robot changed the title E2E test for GCP provider test: add e2e test setup for GCP provider Jan 9, 2025
aramase
aramase requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor nits!

test/bats/gcp.bats Outdated Show resolved Hide resolved
test/scripts/run-e2e-gcp.sh Outdated Show resolved Hide resolved
test/scripts/run-e2e-gcp.sh Outdated Show resolved Hide resolved
test/scripts/run-e2e-gcp.sh Outdated Show resolved Hide resolved
test/scripts/run-e2e-gcp.sh Outdated Show resolved Hide resolved
test/scripts/run-e2e-gcp.sh Show resolved Hide resolved
test/scripts/run-e2e-gcp.sh Outdated Show resolved Hide resolved
aramase
aramase reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash to a single commit after resolving #1701 (comment)

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

Please squash to a single commit after resolving #1701 (comment)

Done.

aramase
aramase reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, dargudear-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@aramase
Copy link
Member

aramase commented Jan 10, 2025

/retest-required

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.50%. Comparing base (87f51ec) to head (347037a).
Report is 102 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1701      +/-   ##
==========================================
+ Coverage   35.83%   36.50%   +0.66%     
==========================================
  Files          63       63              
  Lines        3759     4526     +767     
==========================================
+ Hits         1347     1652     +305     
- Misses       2268     2731     +463     
+ Partials      144      143       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 10, 2025 •
edited
Loading

@dargudear-google: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secrets-store-csi-driver-image-scan 347037a link false /test pull-secrets-store-csi-driver-image-scan

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit bb0c538 into kubernetes-sigs:main Jan 10, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase requested changes

@nilekhc nilekhc Awaiting requested review from nilekhc

Assignees

@aramase aramase

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate remaining CI jobs to community infra by ~August 1st
4 participants
@dargudear-google @k8s-ci-robot @aramase @codecov-commenter