-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: create lbaas in specified subnet #2339
base: main
Are you sure you want to change the base?
🐛 fix: create lbaas in specified subnet #2339
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @simonostendorf. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
What this PR does / why we need it:
The load balancer should be created in the specified lb network if it is defined and it exists. This does not work, see issue #2149.
This PR tries to fix this by writing the read info for the lb network to the status.
I did lots of debugging and found out that the network and subnet info is read in every reconcile loop, written to the local variables but is not saved in the openStackCluster.Status.apiServerLoadBalancer.loadBalancerNetwork field. I tried to fix this by adding the needed line(s).
I also added some more info for the lb subnet to the status to look equal to the normal cluster subnet status.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):fixes #2149
Special notes for your reviewer:
TODOs: